Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DependencyInjection] Documented the new @> shorthand #20528

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[DependencyInjection] Documented the new @> shorthand #20528

merged 1 commit into from
Jan 10, 2025
+8 −0

Conversation

chx
Copy link
Contributor

@chx chx commented Jan 6, 2025

Fixes #20525

@carsonbot carsonbot added this to the 7.3 milestone Jan 6, 2025
@carsonbot carsonbot changed the title Documented the new @> shorthand [DependencyInjection] Documented the new @> shorthand Jan 6, 2025
alamirault
alamirault reviewed Jan 6, 2025
View reviewed changes
service_container/service_closures.rst
# In case the dependency is optional
# arguments: [!service_closure '@?mailer']

# Using the shorthand
# arguments: ['@>?mailer']

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add versionadded directive. Maybe after the last seealso

.. versionadded:: 7.3

    The ``@>`` shorthand was introduced in Symfony 7.3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this sufficient? I also reordered the examples so both shorthands are together.

@javiereguiluz javiereguiluz merged commit 092e1f1 into symfony:7.3 Jan 10, 2025
2 of 3 checks passed
@javiereguiluz
Copy link
Member

Thanks @chx.

While merging we did some minor tweaks because inside versionadded we should only mention that Symfony added this syntax in 7.3 version. We remove these versionadded directives on each major version (i.e. in Symfony 8.0) so we don't include the real contents inside them. In any case, most of your contribution remained as is. Thanks.

@javiereguiluz javiereguiluz mentioned this pull request Jan 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamirault alamirault alamirault left review comments

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chx @javiereguiluz @alamirault @OskarStark @carsonbot